-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified apps folder search to look for apps instead of brjs-apps. #1417
Conversation
got two small issues with this ticket:
FATAL@null line:-1 col:-1 : org.xml.sax.SAXParseException; Premature end of file. |
Since the app checking code was written we've done this. You're right though we should probably only consider something an app if
IMO this is the correct behaviour and the creation of the apps dir should be the responsibility of another part of the code. Whenever a BRJS is created it is populated using the templates, this is what creates the |
the thread sleep time
Fixed issues and merged the |
… of the app.conf file.
I've also added to this PR a change so the discovered app log is only printed the first time apps are used since it looked like this was causing problems with some observer plugins. |
I've also fixed the bug where the |
…apps-1408 Modified apps folder search to look for apps instead of brjs-apps.
Fixes issue #1408.
I have changed the expected apps directory to
apps
, which must be located next to thesdk
. Otherwise, the current working directory will be the apps location. I have also modified all our tests accordingly.